Feed icons missing in views blocks and pages

Fix confirmed.

Actually, this probably needs test coverage.

Wonderful, thank you!

+++ b/core/modules/views/src/ViewExecutable.php
@@ -124,6 +124,13 @@ class ViewExecutable {
+  /**
+   * Feed icons attached to the view.
+   *
+   * @var array
+   */
+  public $feed_icon = array();

The template implies that we only expect one feed icon to be here - not mulitple see views-view-html.html.twig. And this should be a single render array.

This works on pages atm because feeds are added to #attached. If you had multiple and they were using the property (as with blocks), it could just keep overwriting the same feed_icon property too. Not the best. So, I think we should rename this to feedIcons and assume everywhere this is an array of feed icon render arrays. We might also want to update the template too, as Alex suggested in #9; this looks like it should just be singular to actually nothing is stopping multiple icons getting rendered in there currently.

Great catch. I wonder if an alternative solution is to just change it from an array of feed icon render arrays to just a single feed icon render array? That'd make it very easy to fix this patch.

I guess the worry is then that if there are multiple Feed displays, that only one will be shown. But that's already the case in HEAD, plus it seems very much an edge case. Supporting multiple feed icons feels like a new feature.

Why did you do the renaming you said you wouldn't do in #12?

Should we expand the issue to also fix the icons in pages itself?

Here is a reroll. I want to see if this does fix what we talked about in the other issue.

EDIT: Yep, certainly works ok. I must have been going crazy Wim!

+++ b/core/modules/views/src/ViewExecutable.php
@@ -124,6 +124,13 @@ class ViewExecutable {
+  /**
+   * Feed icons attached to the view.
+   *
+   * @var array
+   */
+  public $feedIcons = array();
+
   // Exposed widget input
 
   /**
diff --git a/core/modules/views/templates/views-view.html.twig b/core/modules/views/templates/views-view.html.twig

diff --git a/core/modules/views/templates/views-view.html.twig b/core/modules/views/templates/views-view.html.twig
index f839ef9..5070c42 100644

index f839ef9..5070c42 100644
--- a/core/modules/views/templates/views-view.html.twig

Should we instead try to add a new setter/getter in a follow up?

#19: hehe :) np!

I think we should change the views twig templates to use a feed_icons class instead of feed_icon in views-view.html.twig and views-view--frontpage.html.twig.

The only css that currently applies to it is in bartik's style.css - and this is not for this div at all - it's for each each themed by feed-icon.html.twig

.feed-icon,
.contextual-links a,
.toolbar a {
  border-bottom: none !important;
}

I think this is the right title now.

Very fair point. Changed.

Does this need tests for the page display as well?

I think it is good in the current way. Theoretically introducing setters/getters could be done, but the pure benefit from that
is not much. We already use the public property on the object, so not a big deal to document it and rename it.

This issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 15ddad3 and pushed to 8.0.x. Thanks!