I started this feature, but it needs more work.

http://cgit.drupalcode.org/profile_status_check/commit/?id=3889750

Ideally the patch lookup will get the status of the issue on Drupal.org and include that in the report. Currently it just converts the patch to a link if the patch starts with the node # so the user can look it up as long as the person who generates the patch starts the patch with the issue's node #. The new recommended patch naming for git tells users to use git diff 7.x-1.x > [project_name]-[short-description]-[issue-number]-[comment-number].patch. I don't use that pattern, but we should obviously support it.

So instead of just checking $patch_parts[0] is_numeric we need to check each node then check Drupal.org to see if that is actually a node.

I was thinking we also needed to scan additional directories in a module for patches (like a patch to an include), but if we just support the standard method for generating patches for Drupal modules, all patches should be done from the project/module's root dir.

Comments

  • kreynen committed d091c48 on
    updated pattern matching for finding nid in patch for #2351525
    
kreynen’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.