Hi,

Is there plans to introduce D8 version of this module?
I would like to help you with development of this version or to implement it from scratch.

CommentFileSizeAuthor
#11 stop_spam_regs-drupal_8-2317693-11.patch28.69 KBshkiper
#5 stop_spam_regs-drupal_8-2317693-4.patch48.39 KBshkiper
#3 stop_spam_regs-drupal_8-2317693-3.patch40.24 KBshkiper

Comments

shkiper’s picture

shkiper commented
Issue summary: View changes
spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Hi. Currently no plans to migrate this module to D8. If you want to provide a new D8 version, you are highly welcome.

shkiper’s picture

shkiper commented
StatusFileSize
new stop_spam_regs-drupal_8-2317693-3.patch40.24 KB

Here is the patch to port Stop spam registrations module to Drupal 8.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Active » Needs work

Nice job, andrii! One question - according to this patch, you have dropped list of predefined "blacklisted" domains. Any reasons to do this>

shkiper’s picture

shkiper commented
Status: Needs work » Needs review
StatusFileSize
new stop_spam_regs-drupal_8-2317693-4.patch48.39 KB

I lost the function with this list. It is available in new patch.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Version: 7.x-1.0-beta1 » 8.x-1.x-dev

I've created new branch 8.x, so now possible to use simplytest.me to test your patch.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Need just wait for a while when a new branch from this project will be available there.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs review » Needs work

Ah, didn't note initially - file LICENSE.txt shouldn't be included in patch as well. It adds automatically when new release is published on drupal.org.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented 
+++ b/src/Form/StopSpamRegsSettingsForm.php
@@ -0,0 +1,126 @@
+  public function getFormId() {
+    return 'stop_spam_regs_settings_form';
+  }

As far as I know, currently form ID is automatically generated. So no necessarity in this method anymore.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

But I've tested module on simplytest.me - behavior is correct, nice job!

shkiper’s picture

shkiper commented
Status: Needs work » Needs review
StatusFileSize
new stop_spam_regs-drupal_8-2317693-11.patch28.69 KB

I've updated my patch and made module compatible with current Drupal 8 version. getFormId method is required

  • Spleshka committed f058260 on 8.x-1.x authored by shkiper 
    Issue #2317693 by shkiper, Spleshka: Drupal 8 version
spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs review » Fixed

I've commited your patch & created a new D8 release. Thanks a lot for you work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.