I think the "amount" and "Pay" form elements should be weighted at the bottom of the whole form, which is a lot more intuitive as often fields of Payment content type are required for payment to proceed, so they should be by default on top.

CommentFileSizeAuthor
#7 payment_donation_2316281_7.patch2.96 KBxano
#2 payment_donation_2316281_2.patch2.09 KBxano
#1 rearranging_form-2316281-1.patch771 bytesluke_nuke

Comments

luke_nuke’s picture

luke_nuke commented
StatusFileSize
new rearranging_form-2316281-1.patch771 bytes

I'm attaching a patch for this.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_donation_2316281_2.patch2.09 KB

That's not going to work, because field weights can be arbitrary. Instead, the button should be wrapped by an actions element and the amount should be exposed as an extra field.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Needs work

This needs changes in the validation and submission handlers too.

The last submitted patch, 2: payment_donation_2316281_2.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

Xano queued 2: payment_donation_2316281_2.patch for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_donation_2316281_7.patch2.96 KB

Re-roll, and incorporated #3.

Xano queued 7: payment_donation_2316281_7.patch for re-testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Could you please test this patch and post your feedback here?

luke_nuke’s picture

luke_nuke commented

Sorry for lack of contact from me, I have a lot of work lately, so it's hard for me to find time to test this. I won't be able to look at it like two more weeks at least, unfortunately. I will try to test this, when I will have some time.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Great! Thanks :)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Bump. Could you please review this patch?

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

  • Xano committed e205755 on 7.x-1.x authored by Luke_Nuke 
    Issue #2316281 by Xano, Luke_Nuke: Move "amount" input and submit button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.