This patch allows a user to configure the BrowserSync settings via the UI. The settings are theme specific and are accessed via the theme settings page (Appearance > Settings > Theme Name). It allows a fallback to the settings.php configuration if required. The settings: browsersync_enabled_for_nonadmin , browsersync_enabled_for_admin and path based options have been removed as it is now theme specific rather than path specific.

The readme has also been updated to reflect the new configuration instructions.

CommentFileSizeAuthor
0001-Add-a-settings-ui.patch11.86 KBjez500

Comments

  • jorgegc committed 2fc8d34 on 7.x-1.x 
    Issue #2298167 by jez500: Add a settings UI for configuration options.
jorgegc’s picture

jorgegc commented
Status: Active » Fixed

Hi @jez500,

Now that Browsersync is stable enough and we know exactly what we need to configure it, I finally managed to get the settings out of the settings.php!

Thanks

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks. I like the fact that this is now configurable from the UI, but it seems that there are less settings available.

What happened to settings like browsersync_version, browsersync_enabled_for_nonadmin and browsersync_enabled_for_admin? Are these still available through code, have they become obsolete, or were some features removed?

jorgegc’s picture

jorgegc commented

Hi @marcvangend,

All the settings have been moved from the settings.php file to the theme settings. During the process all the variables that we had because BrowserSync 0.9.x was still supported (e.g browsersync_version) were removed too as they are no longer needed as of 1.x.

As for browsersync_enabled_for_nonadmin and browsersync_enabled_for_admin, they were just a quick workaround the fact that we didn't have these settings nicely exposed through the UI, but now we do.

If there is functionality that you are missing please create a ticket for it or jump on IRC and we will discuss :-)

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks for the quick reply and explanation, Jorge. I didn't actually miss functionality yet, I was just curious where the extra settings went. In case I do encounter missing features (or think of nice-to-have new ones :-)), I'll let you know.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.