Currently the slack module doesn't pass coder-review.

CommentFileSizeAuthor
#1 slack-2284737-cleanup.patch5.62 KBskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new slack-2284737-cleanup.patch5.62 KB

The attached patch fixes the issues found by coder-review. It also removes the empty optional argument from variable_get() calls and uses existing slack module functions instead of direct variable_get() calls.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (fixed)

Hello skwashd.
Thank you for your feedback.

https://www.drupal.org/coding-standards#indentin All text files should end in a single newline (\n)