Are there plans to migrate this for Drupal 6 compatibility?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | recipe-module-es.tar_.gz | 2.62 KB | tatxe |
Are there plans to migrate this for Drupal 6 compatibility?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | recipe-module-es.tar_.gz | 2.62 KB | tatxe |
Comments
Comment #1
brdwor commentedI have began to look at it. Is anyone else working on this?
Comment #2
marble commentedI got an email from someone interested in working on it, but have not heard from that person recently. I had thought that it might be a good idea to try to move towards using CCK, as people seem to want the ability to turn yield off, or don't want the ingredients organised that way etc. It might be worth seeing if there's a way to add recipe's extra functionality (yield, recipeML) on top of a node type installer to reduce the amount of recipe specific code. I don't know when I'll get a chance to progress this idea further, and a straight port to D6 might be quicker/easier and also of interest.
Comment #3
marble commentedOh, also, just got this comment on my own website:
http://www.pebble.org.uk/node/20#comment-1
(I've grabbed the code and will put it on pebble.org.uk for download, haven't had a chance to look at it yet.)
Comment #4
tatxe commentedSeems to work fine...
And I make a quick and dirty translation to spanish...
Comment #5
sunfish62 commentedWell, this is awesome! I will definitely try this out tonight. Will this upgrade a 5.x site?
Also, I'd update the README to instruct users to copy the recipe folder into /sites/{all|yoursite}/modules (as per the new Drupal filesystem scheme). I also don't know about whether the 4.7 stuff is needed.
David
Comment #6
sunfish62 commentedI have tried this on a clean installation at home. The general setup worked fine. However, when I tried adding a recipe with new ingredients, I got:
user warning: Out of range value adjusted for column 'link' at row 1 query: INSERT INTO recipe_ingredient (name, link) VALUES ('pure alcohol', '') in D:\wwwroot\sites\all\modules\recipe\recipe.module on line 560.
This occurred with each new ingredient in my fake recipe. I glanced at the code, and I notice that link is supposed to be set in the line before 560:
558 $node_link = db_result(db_query("SELECT nid FROM {node} n WHERE title = '%s'", $name));
559
560 db_query("INSERT INTO {recipe_ingredient} (name, link) VALUES ('%s', '%s')", $name, $node_link);
After that, I'm lost.
Comment #7
marble commentedTry adding:
if (empty($node_link)) { $node_link=0; }
on line 559 there. Does that help?
Comment #8
sunfish62 commentedThat fixes it. Thanks!
Comment #9
brdwor commentedI have created a CCK field module for ingredients. I will post when a couple more "features" of the recipe.module are implemented. (Specifically: autocomplete ingredient names and fraction/decimal handling for quantity.)
I guess the open question is whether a CCK implementation of the recipe.module is the way we move forward or if I should create a drupal project for ingredient.module for this development?
-or-
Is there a need to continue development on the non-CCK version of the recipe.module?
Comment #10
Mr. Frog commentedI'm having a small issue, nothing critical here.
Using Drupal 6.2, everything is fine with the solution from the recipe's module website. (you should consider puting the code on the 6.X modules pages).
But, I created a recipe for 2 yields, all good, but on the Summary table/box, the Yield field is empty, there's nothing in it. But it's there on the RecipeML and on the Print Version.
I don't know what's the problem:
$form['custom_yield_container']['custom_yield'] = array(
'#type' => 'textfield',
'#default_value' => $node->yield,
'#size' => 2,
'#maxlength' => 4
);
looks fine to me, but $node->yield doesn't show anything. If I put anything else, it's printed there. $node->yield doesn't seem to have any value in that function.
Here's an example:
http://www.froggystyle.ca/?q=node/3
Thanks!
Comment #11
sunfish62 commentedMr. Frog--
This is a separate issue, and you should report it as such. I took a look around the issues here, and it's not listed. There is a comment on the developer's website for this module that identified the problem. It would be good if you submitted this as a separate bug here.
Cheers,
David
Comment #12
marble commentedI think ultimately moving to CCK fields is the way forward, but we shouldn't lose functionality in doing so, and we need an upgrade path for existing users. Does anyone know if drupal's CVS policy allows for creating an extra branch for the CCK work? I think until it's ready we should put the 6.x straight port into CVS. (Come to think of it, we should also do a 5.x release.)
brdwor, what would be your preference?
Comment #13
brdwor commentedI put the 6.x code into CVS. I created a 5.x-1.0 release and a 6.x-0.1 release. I also created a branch for 6.x.
We can then use HEAD for cck development, initially compatible with 6.x but, we can have an inital goal to implement as feature complete with CCK for 7.x (expecially if cck makes core). In the event that it is not feature complete by 7.x, we can then choose to create a 7.x branch from the 6.x branch and continue working in HEAD on the cck version. Does this seem okay?
I didn't commit any cck related files yet. Let's open another issue tracker for that. Reopen this issue if there are any problems with this plan.
Comment #14
brdwor commentedComment #15
brdwor commentedSpanish translation committed also. Thanks, tatxe.
Comment #16
marble commentedAwesome! Thanks, brdwor!
Comment #17
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #18
scottprive commentedFound another Spanish translation here. I don't see it in CVS (and there's another es patch pending in a different issue).
Just updating the subject primarily so I can find this translation and use it, if the other one proves incomplete.