quick edit page runs in endless loop if module is enabled.

TypeError: carriers[$(...).val(...)] is undefined

var defaultUrl = carriers[$('#edit-carrier-url').val()].url;

window for quick edit will not open

Perfect Module

Comments

fugazi’s picture

Issue summary: View changes
pyrello’s picture

fugazi - Hey, I am not currently working with Drupal anymore, so I am not in a good position to fix this bug for you. If you would like to submit a patch, I can commit it for you.

Sorry for the inconvenience.

Sean

fugazi’s picture

Hello Sean,
That would be very nice if they would do that. It is a great module and I would like to inserting. What should I do for you that you can help. I am pleased with your response.

Best Regards
Patrick

pyrello’s picture

Patrick - if you know any other developers that are currently working with Drupal and who would be willing to debug and contribute a patch, that would probably be the best. Short of someone sponsoring continued development of the module, I really just don't have the time to do anything more involved than committing patches.

fugazi’s picture

many thanks for the answer. That's a pity they did not find the time. I would also buy a beer. I'll be watching perhaps there is someone who wants to continue to cultivate here. I buy beers.

Thank you and best regards

fugazi’s picture

until now, the error could be corrected:

diff --git a/js/simple-package-tracking.js b/js/simple-package-tracking.js
index 7d60f15..9c52452 100644
--- a/js/simple-package-tracking.js
+++ b/js/simple-package-tracking.js
@@ -7,9 +7,11 @@
 			var defaultUrl = '';
 			if (carriers) {
 				if ($('#edit-carrier-url').val() != 'none') {
-					var defaultUrl = carriers[$('#edit-carrier-url').val()].url;
-					$('#edit-tracking-url')[0].value = defaultUrl
+					//var defaultUrl = carriers[$('#edit-carrier-url').val()].url;
+					//$('#edit-tracking-url')[0].value = defaultUrl
 					$('#edit-tracking-url').attr('disabled', true);
+                                        $("#edit-tracking-carrier option[value='new']").attr("selected", "selected");
+                                        $('#edit-carrier-new').show();
 				}
 				$('.form-item-carrier-new').hide();
 				$('#edit-tracking-carrier').change( function() {

from time to time I still get an error: An AJAX HTTP error occurred.

fugazi’s picture

StatusFileSize
new895 bytes

first patch I hope it works

pyrello’s picture

Status: Active » Needs review

Setting to Needs review so it can be vetted. If you know anyone else who can try out this patch, I'd appreciate it.

Status: Needs review » Needs work

The last submitted patch, 7: simple_package_tracking-2269901.patch, failed testing.

pyrello’s picture

Patrick, it looks like there was an issue with the patch. Can you review and re-submit?

fugazi’s picture

StatusFileSize
new895 bytes
fugazi’s picture

I'm not a profi but I seem to be only the name of the patch was wrong

pyrello’s picture

Status: Needs work » Needs review

When you submit a patch, go ahead and set the status of the issue to "Needs review". This triggers the testing bot to queue up the patch to be tested.

Status: Needs review » Needs work

The last submitted patch, 11: 2269901-simple-package-tracking.patch, failed testing.

fugazi’s picture

ok I have to read again why the name of the patch is wrong. Since this is my first, it's totally new to me. Did not that makes it so much work :)

pyrello’s picture

Patrick, I don't know if you noticed, but on the patches that failed testing, there is a link to view the testing results. That should provide you with any information you need to fix the issue with the patch.

fugazi’s picture

I've already seen it, but he writes that the filename is wrong, and would not meet the standard. well, also do not know any further. but I look at it tomorrow again to

fugazi’s picture

StatusFileSize
new890 bytes
fugazi’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 18: 2269901-simple-package-tracking.patch, failed testing.

fugazi’s picture

StatusFileSize
new851 bytes
fugazi’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 21: 2269901-simple-package-tracking.patch, failed testing.

fugazi’s picture

StatusFileSize
new3.9 KB
fugazi’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 24: 2269901-simple-package-tracking.patch, failed testing.

fugazi’s picture

fugazi’s picture

StatusFileSize
new1.79 KB
fugazi’s picture

Status: Needs work » Needs review
fugazi’s picture

Status: Needs review » Reviewed & tested by the community

  • pyrello committed 4d5c51e on 7.x-1.x
    Issue #2269901 by fugazi: Fix javascript TypeError
    
pyrello’s picture

Status: Reviewed & tested by the community » Fixed

Commit patch. See above comment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.