Very minor issue with the responsive Bartik theme.

Applies a top margin to .content but one of the local task tabs has the class .content when in the panelizer screens.

CommentFileSizeAuthor
#5 diff.txt508 bytesmjohnq3
panopoly-theme.jpg78.38 KBjamestombs

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Project: Panopoly » Responsive Bartik D7

Thanks for the bug report!

Moving to the Responsive Bartik project. Here's the line in it's code:

http://drupalcode.org/project/responsive_bartik.git/blob/refs/heads/7.x-...

mjohnq3’s picture

mjohnq3 commented

That CSS was copied directly from Bartik so all 1 million + Drupal sites have this "problem."

mjohnq3’s picture

mjohnq3 commented
Project: Responsive Bartik D7 » Panopoly

Pushing this issue back to Panopoly.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Hrm. If we can't fix this in Responsive Bartik, I'm not sure where the correct place is. I don't think Panelizer can do anything about it, it's just declaring the tabs in hook_menu() and Drupal is adding that class. We try and get this fixed in upstream Drupal 7's Bartik, but that will take time...

mjohnq3’s picture

mjohnq3 commented
Project: Panopoly » Responsive Bartik D7
StatusFileSize
new diff.txt508 bytes

Changing margin-top from 10px to 0 on class .content and changing margin-bottom from 0 to 10px on class .meta accomplishes the same thing and seems to work. See attached diff.txt.

Moving this back to Responsive Bartik.

mjohnq3’s picture

mjohnq3 commented
Status: Active » Needs review

Let's review this change.

  • Commit 495a929 on 7.x-1.x by mjohnq3: 
    Issue #2193559: Minor CSS issue with local task tabs.
mjohnq3’s picture

mjohnq3 commented
Status: Needs review » Fixed
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Works great in my testing, thanks! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.