I set the limit to 3 and only flagged 2 of them, when Hide flag links is checked it shows
Notice: Undefined variable: link_href in include() (line 46 of /var/www/drupal/sites/all/modules/contrib/flag/theme/flag.tpl.php)
All the flag links are hidden even though I havent reached the limit.

CommentFileSizeAuthor
#3 link_href_notice-2154219-3.patch3.66 KBtheaidem
#1 link_href_notice-2154219-1.patch1.16 KBtheaidem

Comments

theaidem’s picture

theaidem commented
StatusFileSize
new link_href_notice-2154219-1.patch1.16 KB
theaidem’s picture

theaidem commented
Status: Active » Needs review
theaidem’s picture

theaidem commented
StatusFileSize
new link_href_notice-2154219-3.patch3.66 KB

Hi yuchuan1. Please try the patch

Terragg’s picture

Terragg commented

[ PHP 5.2.17 / Drupal 7.26 / Flags 3 ]

Was seeing the same issue as yuchuan1. Applied patch link_href_notice-2154219-3.patch, now Limiter works as expected.

Thanks.

markwk’s picture

markwk commented
Status: Needs review » Reviewed & tested by the community

I've reviewed and test this as well. I'll commit this change shortly and reroll a new release.

  • Commit fcbe971 on 7.x-1.x authored by theaidem, committed by markwk: 
    #2154219: fix for problems when hiding flag links at limit
markwk’s picture

markwk commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

becometa’s picture

becometa commented

Hiding the flag link also makes the admin_menu not visible on page when link is hidden.

  • Drupal 7.27
  • Flag limiter 7.x-1.0-alpha1
  • Administration menu7.x-3.0-rc4
  • Administration menu Adminimal Theme 7.x-1.5