There seems to be an unnecessary dependency on the iDeal module. The only reference I can see is the use of a "define" (IDEAL_MAXIMUM_AMOUNT) when setting the default maximum donation amount.
And I don't see the need for a dependency on the Currency module either. The donation form doesn't allow for the end-user to select a currency. This module has "EUR" hard-coded into it, with no way to change it other than (I guess) HOOK_form_alter. Not really user- OR developer-friendly, is it?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | payment_donation_2137143_6.patch | 1.89 KB | roderik |
| #1 | payment_donation_2137143_1.patch | 3.04 KB | xano |
Comments
Comment #1
xanoComment #2
xanoCan you confirm whether this works for you?
Comment #3
extexan commentedYes, it's fine now. Thanks.
Comment #4
xanoThanks!
Comment #5
roderikActually, it doesn't work for new installations. Generates a fatal error because the currency variable isn't set.
Also, the block UI doesn't show the currnency selector.
Comment #6
roderikOh. #5 made it possible to set the currency variable, but this one also prevents the fatal exception if the currency variable isn't set.
Comment #7
xanoThanks! Committed.
Comment #8
a.ross commentedPlease roll another stable release, as 1.1 doesn't work because of this bug.
Comment #9
xanoReleases are not made every time a critical issue is fixed. As it happens, we need to fix #2159001: Catch payment validation exceptions during form validation as well before publishing the next release.
Comment #10
a.ross commentedWell, as 1.1 is just unusable (and I struggled with it myself an hour yesterday) and this presumably fixes it. Normal release policies dictate that a new release should be made instantly or at the very least the broken release should be pulled until a new release can be made.
I'll just use the dev release, I'm but concerned about other users...