Closed (fixed)
Project:
KISSmetrics
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2013 at 05:19 UTC
Updated:
21 Oct 2013 at 21:20 UTC
Jump to comment: Most recent file
The kissmetrics_user_id() function can be improved in a couple of areas:
- It currently prioritizes the UID of logged in users over the SID provided by the Session API module which prevents it from tracking users between log in/out.
- It doesn't support the Session Cache module which provides a pluggable data storage mechanism, allows users to be tracked between browsers and can be configured to use the UID of an authenticated user as the SID.
- There is no way to choose which ID provider to use when two or more provider modules are enabled.
- There is no way to create a custom ID provider.
- It doesn't take advantage of drupal_hash_base64() to simplify the ID generation process for anonymous users if no session module is installed.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | improve-user-id-generation-2102729-3.patch | 2 KB | devin carlson |
| #2 | improve-user-id-generation-2102729-2.patch | 6.09 KB | devin carlson |
| #1 | improve-user-id-generation-2102729-1.patch | 6.09 KB | devin carlson |
Comments
Comment #1
devin carlson commentedA patch to address the issues in the OP by allowing for custom ID providers and providing an interface for for selecting between available providers. Support for the Session API and Session Cache modules is included out of the box.
Comment #2
devin carlson commentedAn updated patch that fixes an issue where the currently configured ID provider is not found in the array of available providers.
Comment #3
devin carlson commentedA new patch which reuses the identities set by the JavaScript library and to only identify/alias users as necessary when they first log in.
Comment #4
devin carlson commentedCommitted #3 to KISSmetrics 7.x-1.x.
http://drupalcode.org/project/kissmetrics.git/commit/084edfe