In provider.js you use escape es an url encode function. With some unicode symbols, this gives error as it is not save for url. e.g. ä should be %C3%A4 not %E4

User encodeURI instead

CommentFileSizeAuthor
#1 social_links-fix_javascript_escape-2068879-1.patch523 bytesvalkum

Comments

valkum’s picture

valkum commented
Status: Active » Needs review
StatusFileSize
new social_links-fix_javascript_escape-2068879-1.patch523 bytes
andrea_omitsis’s picture

andrea_omitsis commented

In my case I had to change this line: 

$link['#options']['attributes']['title'] = variable_get('site_name') . ': ' . check_plain($wrapper->label());

to: 

$link['#options']['attributes']['title'] = variable_get('site_name') . ': ' . $wrapper->label();

check_plain() was already encoding the title (wrong in html), so without it javascript encoding is enough

zach.bimson’s picture

zach.bimson commented
Issue summary: View changes

Hey guys,

We currently working on a stable D8 version of this module!
Will look at getting these patches reviewed asap.

Thanks,
Z

  • zach.bimson committed b7cb4c2 on 7.x-1.x authored by valkum 
    Issue #2068879 by valkum: Don't use escape for parts of a URL in...
zach.bimson’s picture

zach.bimson commented
Status: Needs review » Fixed
zach.bimson’s picture

zach.bimson commented
Status: Fixed » Closed (fixed)