PayPal error: The link you have used to enter the PayPal system contains an incorrectly formatted item amount.

Please provide step-by-step instructions on how to reproduce the problem using a clean installation of the dev versions of all required projects.

Bump. Can you provide instructions to reproduce the problem?

I ran into the same problem.

I discovered that in the paypal_payment_pps.module (function paypal_payment_pps_form_redirect) line 197,
$payment->totalAmount(TRUE) uses a float format (in my case I get 3 decimals).

To fix the issue, I added the round function.
'amount_1' => round($payment->totalAmount(TRUE), 2),

otouma

Can you provide a patch that makes the change and a link to the relevant part of Paypal's documentation that describes why the module's current behavior is incorrect?

Same issue here. In my case the error was caused by a discount on a product in drupal commerce. This generates an order total with more then two digits after the decimal marker.

The patch no longer applies.

@mvdve: it would be nice if this patch can be included in version 7.x-1.1. Can you re-roll it?

Missed your last post sorry, the updates are not yet shown properly on the new drupal 7 dashboard. I will upload a new patch tonight.

New patch for re-roll.

And I missed your last patch for the exact same reason, it seems. Thanks! QA requires me to repeat my question from #6 again, though: Can you provide a link to the relevant part of Paypal's documentation that describes why the module's current behavior is incorrect? We need to make sure that this fix is the correct one.

The PayPal API says "Any valid currency amount" (page 116).
It is possible to send a amount with more then two digits after the decimal pointer when for example a discount rule is used.

The thing is that some of the world's currencies actually have more than a 100 subunits (and thus more than 2 decimals). PayPal's documentation is absolutely unclear about these things.

Thanks for the patch!

The result from issue 2063119 has overwritten this patch.

The PayPal API says "Any valid currency amount" (page 116).

The link doesn't seem to work anymore. Do you know where the information can be found now?

Hi,

got the same Problem also on 1.1. (incorrectly formatted item amount).

Had to replace on paypal_payment_pps.module line 196
$data['amount_' . $index] = $line_item->totalAmount(TRUE);
with
$data['amount_' . $index] = (string) round($payment->totalAmount(TRUE), 2); // HACK PATCH

Cheers,
Matthias

If you're using discounts you'll get the same error when passing your shopping cart to PayPal because it doesn't accept negative values.
Proposed solution to work with discounts:
Alter for each command on line 193 of paypal_payment_pps.module to

foreach ($payment->line_items as $line_item) {
	  if ($line_item->unitAmount(TRUE) > 0) {
    //$data['amount_' . $index] = $line_item->unitAmount(TRUE);
	$data['amount_' . $index] = (string) round($line_item->unitAmount(TRUE), 2);
	//$data['amount_' . $index] = (string) round($payment->totalAmount(TRUE), 2);
    $data['item_name_' . $index] = $line_item->description;
    $data['quantity_' . $index] = $line_item->quantity;
    $index++;
	  }
	  if ($line_item->unitAmount(TRUE) < 0) {
		  $data['discount_amount_cart'] = (string) abs(round($line_item->unitAmount(TRUE), 2));
	  }
  }

I don't know how to write a patch, so I suggest to review this alter and create a patch.

Greetz

Vincent

Why don't we use the currency module's capabilities Currency::roundAmount() to round to the right number of decimal places for all currencies?

Here is a patch that uses Currency::roundAmount() to solve this properly.

@Vincent Rommelaars: I think discounts are a separate issue. I have fixed that in #2981152: Payment fails if line item has negative amount (e.g. for discounts).

Committed #25 to 7.x-1.x