The autocomplete path doesn't point to the correct widget settings.

Additionally the validation on the autocomplete doesn't take into account for spaces in customer names.

CommentFileSizeAuthor
#3 xero-fix-autocomplete-issues-2033635-2.patch4.93 KBmradcliffe
#1 xero-fix_autocomplete_issues-2033635-1.patch1.29 KBJoshua Hesketh

Comments

Joshua Hesketh’s picture

Joshua Hesketh commented
Status: Active » Needs review
StatusFileSize
new xero-fix_autocomplete_issues-2033635-1.patch1.29 KB

patch provided

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

Sorry for the tardy reply. This looks good. I am writing a test for it at the moment before committing.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new xero-fix-autocomplete-issues-2033635-2.patch4.93 KB

Hmm, I found some additional issues with my initial implementation which my test uncovered.

The autocomplete widget doesn't save the field item correctly in form_set_value().

Can you see if this patch behaves for you?

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.