A boolean option in the UI should use a single checkbox, not a radio. (The exception is when the on/off state is not easily conveyed by a single statement you either check or don't.)

The options for whether to load retweets and replies would be much better represented as a checkbox for each one.

Furthermore, a negative should not be used.

So:

[] Load retweets
[] Load replies

Rather than:

Retweets:
() True
() False

Exclude replies:
() True
() False

CommentFileSizeAuthor
#1 2030705.twitter_pull.box-radios-to-checkbox.patch1.28 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Fixed
StatusFileSize
new 2030705.twitter_pull.box-radios-to-checkbox.patch1.28 KB

> Furthermore, a negative should not be used.

Unfortunately, it's twitter API itself that's guilty of using a negative for its option. I'll leave this one to another issue, as we'd need to flip the value on submit to keep our internal configuration consistent with twitter.

Issue #2030705 by joachim: Fixed radios used for boolean options.

joachim’s picture

joachim commented

Backported to 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.