Add content to a group, the group is not associated with the content

Yes, I am using the dev make file:

$ drush make --no-cache --working-copy build-commons-dev.make ../commons-7.x-3.x-dev

Are you not seeing this?

Looking into this more, the $group_id is being passed to commons_bw_partial_node_form(). The $form_state['group_id'] = $group_id; is being set. It is set to 7

Debugging in the commons_bw_partial_node_form_submit():

  // Set the group audience.
  if (!empty($form_state['group_id'])) {
    $wrapper->{OG_AUDIENCE_FIELD}->set(array($form_state['group_id']));
  }
  watchdog('debug', '$wrapper->{OG_AUDIENCE_FIELD}->value(): <pre>'. print_r($wrapper->{OG_AUDIENCE_FIELD}->value()) . '</pre>');
  $wrapper->save();

The result of the debug is:

$wrapper->{OG_AUDIENCE_FIELD}->value() == 1

It should not be 1, it should be 7.

There are other notices and warnings, but don't look like they would affect this? They do come before my debug in the log so they were hit before the $wrapper->save():
Notice: Undefined variable: gids in commons_radioactivity_incident_groups() (line 148 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_radioactivity/commons_radioactivity.module).
Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_node_presave() (line 850 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_trusted_contacts/commons_trusted_contacts.module).
2 of the following:
Notice: Undefined property: stdClass::$form_state in commons_trusted_contacts_node_presave() (line 850 of /Users/rkoberg/Sites/commons-dev/commons-7.x-3.x-dev/profiles/commons/modules/contrib/commons_trusted_contacts/commons_trusted_contacts.module).
Then comes my debug from above.

In #4, I should have wrote:

$wrapper->{OG_AUDIENCE_FIELD}->value() == array(1)

It should not be array(1), it should be array(7).

Not sure what you mean about a patch. Is it just for the debug messages? I have not fixed anything. (anyway one is attached)

I also added:

  watchdog('debug', '$form_state[\'group_id\']: '. $form_state['group_id']);
  // Set the group audience.
  if (!empty($form_state['group_id'])) {
    $wrapper->{OG_AUDIENCE_FIELD}->set(array($form_state['group_id']));
  }
  watchdog('debug', '$wrapper->{OG_AUDIENCE_FIELD}->value(): <pre>'. print_r($wrapper->{OG_AUDIENCE_FIELD}->value()) . '</pre>');
  $wrapper->save();

which produced:

$form_state['group_id']: 7

Ah, OK. Where you able to reproduce? This seems like a showstopper. I am kind of at a loss. Any more help trying to debug would be appreciated. See more info below.

Actually, my previous debugging was not working correctly. I think watchdog was choking on the amount of info I was trying to print out. I changed it to store the result in a variable to display on form view. So in the form_submit, I have:

  if (!empty($form_state['group_id'])) {
    $wrapper->{OG_AUDIENCE_FIELD}->set(array($form_state['group_id']));
  }
  variable_set('debug_commons_bw_partial_node_form_submit_group_ref_before', $wrapper->{OG_AUDIENCE_FIELD}->value());
  $wrapper->save();
  variable_set('debug_commons_bw_partial_node_form_submit_group_ref_after', $wrapper->{OG_AUDIENCE_FIELD}->value());
  variable_set('debug_commons_bw_partial_node_form_submit_new_node_after', $wrapper->value());

And I found a hook_node_insert in commons_groups and added:

function commons_groups_node_insert($node) {
  variable_set('debug_commons_groups_node_insert_node', $node);
  $account = user_load($node->uid);
  commons_groups_first_contribution($account, $node);

Then I dpm() those variables in commons_bw_partial_node_form(). The result:
debug_commons_bw_partial_node_form_submit_group_ref_before = the correct group object
debug_commons_groups_node_insert_node = the new node, but the og_group_ref property is an empty array
debug_commons_bw_partial_node_form_submit_group_ref_after = the correct group object
debug_commons_bw_partial_node_form_submit_new_node_after = the new node, but the og_group_ref property is an empty array

Attached are a couple of screen grabs showing the output of the last two variables.

OK, that is not in the code. I am working on something else now and can't test. If you put that in does it fix the issue? If so can you commit it :)

Confirming fixed.