We should support translating properly, not using t as we are now.

CommentFileSizeAuthor
#4 allow_correct_translation-2015369-4.patch2.91 KBsteven jones
#2 i18n-node_buttons.patch5.53 KBsteven jones

Comments

steven jones’s picture

steven jones commented

i18n is a bit of a nightmare. But we should be able to do something here.
Going after trying to translate the variables might be a good idea.
This might require a cheeky submodule though, and some tests,

steven jones’s picture

steven jones commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new i18n-node_buttons.patch5.53 KB

Here's a patch for review.

Status: Needs review » Needs work

The last submitted patch, 2: i18n-node_buttons.patch, failed testing.

steven jones’s picture

steven jones commented
Status: Needs work » Needs review
StatusFileSize
new allow_correct_translation-2015369-4.patch2.91 KB

Better patch.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

  • Steven Jones committed 2c1f5ef on 7.x-1.x 
    Issue #2015369 by Steven Jones: Fixed Allow correct translation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jadhavdevendra’s picture

jadhavdevendra commented

Not sure why but it is not working for me. I am using Drupal 7.54 & Node buttons edit 7.x-1.0