Placing Commerce Webform field inside fieldset and setting it as mandatory field is not possible at the moment. Validation (_webform_productfield_selection_validate) is not recursive and is hardcoded to look only fields on "top" level of form.

CommentFileSizeAuthor
#5 commerce_webform-check_nested_mandatory_fields-2012940-4.patch2.02 KBjohnennew
#1 commerce_webform-2012940-1.patch3.59 KBrpsu

Comments

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Assigned: Unassigned » rpsu
StatusFileSize
new commerce_webform-2012940-1.patch3.59 KB

This patch fixes issue.

NOTE that same patch also includes change to mandatory/non-mandatory dropdown select list UI visible title, and minor coding standard fixes.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Assigned: rpsu » Unassigned
Status: Active » Needs review
johnennew’s picture

johnennew commented

Thanks for the patch, will look at this when I get a moment.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented

I did not find the place where Webform sets empty values "- Select -" or "- None -" to dropdowns, so I simply set them manually. I think best solution would be to use same value(s) as Webform does.

johnennew’s picture

johnennew commented
Status: Needs review » Fixed
StatusFileSize
new commerce_webform-check_nested_mandatory_fields-2012940-4.patch2.02 KB

Hi @rpsu,

Thanks for your patch submission. I've made some DCS amendments before committing. Also, I think the 'none', 'select' text is the wrong way round? None should be for non-mandatory and select for mandatory fields?

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented

Sure, DCS and reversing none/select the other way around are fine with me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.