As per #2005970: In renderable arrays, #type should provide a #theme suggestion, similar to how drupal_prepare_form() works we should convert item_list renderable arrays to #type.

Issue fork drupal-2010210

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thedavidmeister’s picture

thedavidmeister commented
Status: Active » Postponed

blocked by #1828536: Rename 'type' variable of theme_item_list() to 'list_type'

thedavidmeister’s picture

thedavidmeister commented
Status: Postponed » Active

no longer blocked.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: convert all item_list #theme to #type » Convert all item_list #theme to #type
Version: 8.2.x-dev » 9.x-dev
Issue summary: View changes
Status: Active » Postponed

I can't think of a way to get this in to the 8.x without breaking anything. Let's revisit in 9.x unless you have a proposal for BC in 8.x?

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.x-dev » 8.3.x-dev
Status: Postponed » Active

We can change the content of render arrays in minor releases, so nothing should stop this from happening in 8.x - see https://www.drupal.org/core/d8-bc-policy

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Active
Issue tags: +Novice, +Needs issue summary update

This may still be relevant so think we need a summary update and an MR

Seems like a good task for a first time user.

pcharrat made their first commit to this issue’s fork.

pcharrat changed the visibility of the branch 2010210-convert-all-itemlist to hidden.

pcharrat changed the visibility of the branch 2010210-convert-all-itemlist to active.

pcharrat opened merge request !15569

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented
Assigned: Unassigned » pcharrat
Issue summary: View changes
pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented

Hi,
I’m creating this merge request to ask for your help. I’d like to make sure I’m heading in the right direction before touching multiple areas of the core (80+ locations).
Thanks in advance.

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented
Assigned: pcharrat » Unassigned
Status: Active » Needs review
pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented

Before moving forward and starting to make bulk changes to the numerous instances in the core, I’d like to get an initial review of the general approach:

  • Does the chosen direction seem correct to you in terms of the API and render system?
  • Are there any backward compatibility (BC) issues or use cases we should consider right now?
  • Do you recommend a specific strategy for the migration (order, scope, precautions)?
  • Are further tests necessary or strongly recommended?

Thank you in advance for your feedback

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Per the original summary this doesn't appear to be the same task anymore, so if this issue is being taken over for a separate task, we already have a type item_list so not entirely sure why this is needed? Leaving the summary tag but now may be a non novice task.

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented
Issue summary: View changes

pcharrat changed the visibility of the branch 2010210-convert-all-itemlist to hidden.

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented

Hello,
Okay, I'll undo all my work on this issue and restore it to its original state, including its history summary.

smustgrave’s picture

smustgrave commented

My understanding was this was just replacing some instances

smustgrave’s picture

smustgrave commented

Also not saying my understanding is fully correct

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented

To be honest, I thought it didn't exist because I couldn't find any instances of '#type' => 'item_list'. However, I may have misunderstood, and I'd appreciate an example so I can better understand the issue.

smustgrave’s picture

smustgrave commented

Setting a reminder to help out!

catch’s picture

catch
he/him
Primary language English
commented

There are some related issues here:

#311011: [PP-1] Replace links.html.twig with item-list--links.html.twig

#1842140: Remove title and wrapper div from item-list.html.twig

pcharrat’s picture

pcharrat
Primary language French
Location Lyon 🦁
commented

Is there any update on this ticket?