The message text for commons_posts_post_created in commons_posts.features.inc contains a few extra paragraph tags and line breaks.

CommentFileSizeAuthor
#8 commons_posts_message-2003622-8.patch2.62 KBdevin carlson
#7 https://drupal.org/files/commons_posts_message-2003622-7.patch2.67 KBstupiddingo
#2 commons_posts_message-2003622-2.patch2.14 KBstupiddingo
#1 commons_posts_message-2003622-1.patch1.56 KBstupiddingo

Comments

stupiddingo’s picture

stupiddingo commented
Component: Theme » Posts
Status: Active » Needs review
StatusFileSize
new commons_posts_message-2003622-1.patch1.56 KB

Patch to commons_posts.features.inc

stupiddingo’s picture

stupiddingo commented
StatusFileSize
new commons_posts_message-2003622-2.patch2.14 KB
stupiddingo’s picture

stupiddingo commented

Removing tag (need to slow down here)

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch. Works perfectly.

BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Needs review

Oh, the only thing is that is misses an upgrade path (hook_update) to revert the Messages.

BarisW’s picture

BarisW commented
Status: Needs review » Needs work
stupiddingo’s picture

stupiddingo commented
Status: Needs work » Needs review
StatusFileSize
new https://drupal.org/files/commons_posts_message-2003622-7.patch2.67 KB

Not so sure about this. "Learn hook_update_N()" is in my notes from Portland...

devin carlson’s picture

devin carlson commented
StatusFileSize
new commons_posts_message-2003622-8.patch2.62 KB

#7 looks great, thanks for the patch!

The update just needs one tweak; since only the message type is being modified, field instances shouldn't need to be reverted.

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

Reviewed #7/8 through a fresh install of Commons and by upgrading an existing Commons site. In both situations I didn't encounter any issues and the extra WYSIWYG markup was successfully removed.

devin carlson’s picture

devin carlson commented
Version: 7.x-3.2 »
Status: Reviewed & tested by the community » Fixed

Committed #8 to Commons Posts 7.x-3.x.

http://drupalcode.org/project/commons_posts.git/commit/ee0cbf0

stupiddingo’s picture

stupiddingo commented

Thanks BarisW for the review! And thanks Devin for your explanation and assist. I now understand what the field_instance call was doing! It wasn't intuitive to me reading the API.

We'll call hook_update_N achievement unlocked. Time now to hook_update our workflow at the office.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.