Unused $node variable in template.php

Hi Thanks for the patch and good catch. I also had that variable repeated further down in a new dev I pushed yesterday so I fixed that too. I tested this on my local dev and it seems to be fine. I'll push a new release up to 1.x soon but 2.x will stay at dev for now with no release since it's in the very early stages of development.

Hi Samvel, I tired several times to attribute your authorship but nothing worked. To me the documentation on this seems unclear as it did not work for me. I tried these:

git commit --author="asik <asik@1596146.no-reply.drupal.org>"
git commit --author="asik <asik@1596146.no-reply.drupal.org>" -m " Fixing #2001382: Unused $node variable in template.php Unused $node variable in template.php
git commit --author="asik <asik@1596146.no-reply.drupal.org>" -a " Fixing #2001382: Unused $node variable in template.php Unused $node variable in template.php

... but each presented its own issues, none of which I could solve going round with it for an hour or so. Of course now I will have to change the old commit so I am not sure how to do that either.

I'm open to patches being submitted for 1.x but not against the 2.x dev right now, it's in its infancy and I am still sorting things out. Feel free to open an issue and supply patches or make feature requests. As you can see, this project is quite active and I pay a lot of attention to it.

Thanks, Danny

That didn't work as I got an error message that I could not push over what was there now so I relaized I had to ammend the commit. I tried:

git commit --author="asik <asik@1596146.no-reply.drupal.org>" -a --amend -m "Issue #2001382 by Samvel: Unused $node variable in template.php"
git commit --author="asik <asik@1596146.no-reply.drupal.org>" --amend -am "Issue #2001382 by Samvel: Unused $node variable in template.php"

... both seemed successful in committing part but still no joy after pushing, I get:

Pushing to highrockmedia@git.drupal.org:project/bamboo.git
To highrockmedia@git.drupal.org:project/bamboo.git
 ! [rejected]        7.x-1.x -> 7.x-1.x (non-fast-forward)
error: failed to push some refs to 'highrockmedia@git.drupal.org:project/bamboo.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')
hint: before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I tried git pull as suggested but still no joy after I pushed again, it simply showed the old commit message. This thread on stack seems to be what I am after but nothing worked to get the new amended message to push:

http://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-com...

I'm out of ideas, sorry.