We should have a test method that checks the whole tax handling of the module, i.e. check if the right tax rate (take commerce tax into account) is exported.

CommentFileSizeAuthor
#5 tax_rate_test_1996368_5.patch5.84 KBberdir
#5 tax_rate_test_1996368_5-interdiff.txt5.7 KBberdir
#4 tax_rate_test_1996368_4.patch3.68 KBs_leu
#1 tax_rate_test_1996368_1-interdiff.txt9.1 KBs_leu
#1 tax_rate_test_1996368_1.patch15.1 KBs_leu

Comments

s_leu’s picture

s_leu commented
StatusFileSize
new tax_rate_test_1996368_1.patch15.1 KB
new tax_rate_test_1996368_1-interdiff.txt9.1 KB

Here's a first patch and an interdiff against the patch of #11 in #1985814: Exported line item rows ignore pricing rules, please check.

s_leu’s picture

s_leu commented
Assigned: Unassigned » berdir
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

Patch no more applies.

s_leu’s picture

s_leu commented
Status: Needs work » Needs review
StatusFileSize
new tax_rate_test_1996368_4.patch3.68 KB

Here's a reroll against the 7.x-1.x branch

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new tax_rate_test_1996368_5-interdiff.txt5.7 KB
new tax_rate_test_1996368_5.patch5.84 KB

As discussed, fixed the tests, removed the unused setting and slightly moved around the test code to make it easier to understand.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Looks fine at the first sight.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.