There is a typo in hsts.admin.inc which results in HSTS max age not being configurable.

(This patch also fixes a typo in the error message.)

CommentFileSizeAuthor
#10 fix_field_name_confi_validation-1985424-10-D6.patch686 bytesmilodesc
#5 fix_field_name_confi_validation-1089168-5.patch686 bytesmilodesc
hsts.patch1.3 KBmfb

Comments

minoroffense’s picture

minoroffense commented
Status: Needs review » Reviewed & tested by the community

Looks good. I'll roll a new release this morning.

Thanks.

mfb’s picture

mfb
they or he
commented
Priority: Normal » Major

This actually seems "major" since the module is otherwise not too useful.

minoroffense’s picture

minoroffense commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed.

Thanks for the patch! (and sorry it took so long...)

mcarbone’s picture

mcarbone commented
Version: 7.x-1.0-rc1 » 6.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)

Needs to be backported.

milodesc’s picture

milodesc
he/him
commented
Issue summary: View changes
Status: Patch (to be ported) » Needs review
StatusFileSize
new fix_field_name_confi_validation-1089168-5.patch686 bytes

Drupal 6 backport attached.

wwarren’s picture

wwarren commented
Assigned: Unassigned » minoroffense
milodesc’s picture

milodesc
he/him
commented
minoroffense’s picture

minoroffense commented

I think that sentence should read "or out of bounds". Might be a bug in the d7 version too.

minoroffense’s picture

minoroffense commented
Status: Needs review » Needs work
milodesc’s picture

milodesc
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new fix_field_name_confi_validation-1985424-10-D6.patch686 bytes

The sentence looks correct in the D7 version.

Patch attached for the D6 version.

  • minorOffense committed 4ddc4d2 on 6.x-1.x authored by milodesc 
    Issue #1985424 by milodesc: HSTS max age is not configurable due to typo
minoroffense’s picture

minoroffense commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.