Move drupal_map_assoc to a MapArray Utility Component

Just wanted to add my +1 to copyValuesToKeys. The name of this function never made any sense to me.

No idea what to do about the class name.

I suggest Map, since it does have to do with array mapping. I also suggest adding in some PHPUnit tests, as attached.

+++ b/core/tests/Drupal/Tests/Component/Utility/MapTest.phpundefined
@@ -0,0 +1,102 @@
+      array(1, 2, 3, 4, 5),
+      array(
+          1 => 2,
+          2 => 4,
+          3 => 6,
+          4 => 8,
+          5 => 10,

Four spaces instead of two.

^^... or ArrayMap? Either way, a re-roll is called for.

Very nice to be unit testing this function finally :)

+++ b/core/includes/common.incundefined
@@ -2004,28 +2005,13 @@ function drupal_exit($destination = NULL) {
+ * @deprecated as of Drupal 8.0.
+ *   Use \Drupal\Component\Utility\MapArray::copyValuesToKeys() instead.

As for the unicode patch... let's not do this.

+++ b/core/includes/common.incundefined
@@ -2004,28 +2005,13 @@ function drupal_exit($destination = NULL) {
+  return MapArray::copyValuesToKeys($array, $function);

Not 100% certain about this as a name as it only covers the default case and not case when you pass a function.

1. Renamed $function to $callback so that it makes a bit more sense for what it does.
2. Removed the @deprecated key

+++ b/core/lib/Drupal/Component/Utility/MapArray.phpundefined
@@ -0,0 +1,42 @@
+    if (isset($callback) && is_callable($callback)) {

The isset is unneeded here... calling is_callable(NULL) does not produce a warning for me and I have error_reporting set to E_ALL | E_STRICT

Rerolled and made a couple of changes. The tests look good, I haven't used the data providers stuff before, that's a nice idea!

- Changed params to $callable instead of $callback
- Fixed test (Needed static method instead)
- Remove ternary from function (from closed dupe in #19), there is no need for this, it will also make a cope of the array in memory.

It's also a good idea to check the dupe issues you are closing, there could be some changes etc... that could be incorporated. Just closing and doing nothing isn;t a great help...

#21: 1973312-21.patch queued for re-testing.

+++ b/core/tests/Drupal/Tests/Component/Utility/MapArrayTest.phpundefined
@@ -95,7 +95,7 @@ public function providerCopyValuesToKey() {
    * @param $n

just a single nitpick: should be int + provide an @return

Yep, How about a few docs tweaks like this?

Another nitpick.

Ehem I wanted to RTBC it.

#26: drupal-1973312-26.patch queued for re-testing.

Rerolled.

Committed 1649489 and pushed to 8.x. Thanks!