When anonymous session has some content this content is saved on session_regenerate but uid is not overwritten. So after succesful login+regenerate_id -> still having uid 0 in session.

CommentFileSizeAuthor
#1 session_proxy_login-failed-on-non-empty-anonymous-session-native_1970192-1.patch530 bytesregilero

Comments

regilero’s picture

regilero commented
Status: Active » Needs review
StatusFileSize
new session_proxy_login-failed-on-non-empty-anonymous-session-native_1970192-1.patch530 bytes

Here is the patch

regilero’s picture

regilero commented
Status: Needs review » Reviewed & tested by the community

Re-having same bug today, the patch fix the problem...

regilero’s picture

regilero commented
Issue summary: View changes

nope, nothing to say.

jamesharv’s picture

jamesharv commented

+1 RTBC. It would be great to get this committed.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Do I understand the steps to reproduce?

1. use Native backend
2. Have some code that sets data in $_SESSION on a page view
3. On a subsequent page view, that user logs in to the site in some manner
4. The session data from step 2 is lost

jamesharv’s picture

jamesharv commented

Correct except for step 4. The existing session data isn't lost, it's just that the user doesn't get correctly authenticated, because their uid isn't stored in the session. The outcome is that the user is not able to access the features / content to which their user account grants access.

  • Pierre.R committed 8513827 on 7.x-1.x authored by regilero 
    Issue #1970192 by regilero: login fail if anonymous session is not empty...
pounard’s picture

pounard
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Sorry it took me more than 2 years to push this, but now it's done! Once all the issue queue will be drilled down, I will push a new release and mark it as RC since this module is supposed to now tested for almost 4 years long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.