It is not always convenient to determine ip address/ranges for maintenance mode exemption.

Would it be possible to introduce a short lived cookie based alternative, set by the inclusion of a configurable query string?

CommentFileSizeAuthor
#2 maintenance_exempt-query-string-exemption-1957540-2.patch5.24 KBrandallkent
#1 maintenance_exempt-query-string-exemption-1957540-1.patch2.78 KBchris_hall_hu_cheng

Comments

chris_hall_hu_cheng’s picture

chris_hall_hu_cheng commented
Status: Active » Needs review
StatusFileSize
new maintenance_exempt-query-string-exemption-1957540-1.patch2.78 KB

I needed the functionality so I modified and have submitted a patch here.

I used the session to store the exemption once a valid value is found as a query string, makes it easier if you want to run a set of selenium tests for anonymous users when the site is under maintenance or have a bunch of disparate people you need to notify to check the site.

randallkent’s picture

randallkent commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new maintenance_exempt-query-string-exemption-1957540-2.patch5.24 KB

Hey Chris -

Please see the attached patch which is essentially your patch with some minor tweaks. If everything looks good, please add a comment to this issue and set the status to "reviewed & tested by the community" and I'll get it committed!

Thanks!
-Randall

chris_hall_hu_cheng’s picture

chris_hall_hu_cheng commented

Thanks Randal,

All looks good to me, more polished ux also ...

Cheers,
Chris

randallkent’s picture

randallkent commented
Status: Reviewed & tested by the community » Closed (fixed)

  • Commit 6c2f108 on master, 7.x-1.x: 
    Issue #1957540/#2013024 by RandallKent,chris_hall_hu_cheng: add ability...