See: #1803284: "Completing the checkout process" Rules event is not invoked

CommentFileSizeAuthor
#6 idealcommerce_1944360_03.patch929 bytesxano
#3 idealcommerce_1944360_02.patch924 bytesxano
#1 idealcommerce-completing_the_checkout_process_rule_not_fired-1944360-1.patch1015 bytesa.ross

Comments

a.ross’s picture

a.ross commented
StatusFileSize
new idealcommerce-completing_the_checkout_process_rule_not_fired-1944360-1.patch1015 bytes
a.ross’s picture

a.ross commented
Status: Active » Needs review
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new idealcommerce_1944360_02.patch924 bytes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Checkout completion should not be called directly. Instead, the 'pane navigation' should be used, which triggers checkout completion in case of success.

Status: Needs review » Needs work

The last submitted patch, idealcommerce_1944360_02.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new idealcommerce_1944360_03.patch929 bytes
a.ross’s picture

a.ross commented

Thanks. Will be testing this today if possible.

a.ross’s picture

a.ross commented

Doesn't appear to be working. An anonymous checkout wasn't linked to the pre-existing account. That means the event still isn't triggered.

a.ross’s picture

a.ross commented
Status: Needs review » Needs work
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

Linking orders to pre-existing accounts is not within the scope of this issue.

I just tested the patch locally using a fresh Commerce Kickstart 7.x-1.x installation, and the latest ideal-7.x-2.x and ideal_commerce-7.x-1.x from GiT. When iDEAL payments fail, the user ends up at the checkout page he was at before he was redirected to the bank. When they succeed, the checkout is completed.

a.ross’s picture

a.ross commented
Status: Needs review » Reviewed & tested by the community

Sorry, that was a faulty configuration on our end. A rule apparently changed the order status, which caused the tests in commerce_payment_redirect_pane_next_page() to fail, so the event wasn't triggered.

After adjusting this rule it works fine, so this is RTBC. Thanks

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.