In a case where we want to work with multiple order type, we can choose not to share fields for all orders.

But Store » Configuration » Checkout Settings is still global.
That means we need to add a check before trying get data of an associated order field.

CommentFileSizeAuthor
#4 1923258.check_fields_4.patch2.99 KBbojanz
#3 1923258.check_fields_3.patch1.01 KBhaza
#1 1923258.check_fields.patch702 byteshaza

Comments

haza’s picture

haza
Primary language French
commented
Status: Active » Needs review
StatusFileSize
new 1923258.check_fields.patch702 bytes

Patch attached.

jsacksick’s picture

jsacksick commented

This issue also occurs in Commerce, See #1923326: The customer profile checkout pane doesn't check if the associated field exists, a patch has been attached there.

haza’s picture

haza
Primary language French
commented
StatusFileSize
new 1923258.check_fields_3.patch1.01 KB

New patch, we also need to check that in commerce_single_address_pane_checkout_form_submit()

bojanz’s picture

bojanz commented
StatusFileSize
new 1923258.check_fields_4.patch2.99 KB

I agree with the fix.

I moved the check further up, for better clarity. Can you confirm that it still works?

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.