Convert getLeftJoin.sjs in salsa_api_query() to the new class.

CommentFileSizeAuthor
#3 salsa_api-getLeftJoin-1913104-3.patch3.33 KBjohnshortess
#1 salsa_api-getLeftJoin-1913104-1.patch3.33 KBjohnshortess

Comments

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented
Status: Active » Needs review
StatusFileSize
new salsa_api-getLeftJoin-1913104-1.patch3.33 KB

Patch attached.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/salsa_api.incundefined
@@ -188,6 +188,49 @@ class SalsaAPI implements SalsaAPIInterface {
+     //If there are any items, convert them to objects and return.
+    $salsaobjects = array();

One space too much before "//", one too less after it.

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented
StatusFileSize
new salsa_api-getLeftJoin-1913104-3.patch3.33 KB

You're up late. :)

You've also got a good eye! Updated patch attached.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yeah, trained by countless hours of patch reviews :)

Looks good.

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed and pushed. I believe this is the last remaining issue for alpha1 -- I'll tag a release and push later today.

  • johnshortess committed f231f42 on 7.x-1.x, 8.x-1.x 
    Issue #1913104 by johnshortess: Added getLeftJoin method to SalsaAPI...