Closed (fixed)
Project:
Commerce Currency Settings
Version:
7.x-1.0
Component:
User interface
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2013 at 03:38 UTC
Updated:
12 Aug 2013 at 07:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
facine commentedFixed in dev: http://drupalcode.org/project/commerce_currency_settings.git/commit/029821a
Thanks
Comment #2
denisgre commentedHi Manuel,
The patch appears to work well - my site has lost a lot of weight all of a sudden :-).
I will let you know if any other issues show up, otherwise, I think this should be added to the DEV branch ASAP.
Best,
Denis.
Comment #4
ankur.khurana3 commentedNot Working For Me. The Issue still Exists. I am unable to save the Settings. It just toggle back to the original values.
Comment #5
facine commentedWhich version are you using?
What no hard currency?
And what values not saved?
Thanks
Comment #6
eworwa commentedHi, I'm facing the same problem. I already installed the dev version of the module. I set the Code Placement to "Hidden" and Save the form it keeps coming back to "After". But when I set the Code Placemente to "Before" the price it's formatted correctly, so the data it's getting storage in db. I just cannot hide the code from the price output.
Comment #7
facine commentedIn which currency?
Comment #8
dayer4b commentedI'm having the exact same problem as #6.
Currency is Naira (NGN)
Comment #9
dayer4b commentedupdated status
Comment #10
dayer4b commentedincreasing priority to critical.
this bug makes this module useless to me.
Comment #11
facine commented@dayer4b: In which version and which values?
Thanks
Comment #12
dayer4b commentedI'm using 7.x-1.1. I attempted to set the value of code_placement to "hidden" to no success.
Comment #13
webdrips commentedThis took me forever to figure out since variable_get() is kind of funky when it comes to working with form values, but the attached patch should fix the issues of not being able to save the form, although it does break the validation, so maybe someone else can fix that based on the attached patch.
Comment #14
chrinor2002 commentedHi there, I managed to track down the issue to be in the commerce_currency_settings_settings_form_validate() call. The validate uses array_diff() to compare settings provided in the core of commerce with settings applied by the user. The problem is that array_diff() does not work with keys AND values, just values. Here is a patch that will use array_diff_assoc().
Comment #15
tomrishworth commentedPatch in #14 fixes this issue for me.
Thanks
Comment #16
facine commentedCommited in dev version!
Thanks