Hello there,

First of all THANK YOU / GRACIAS for doing this - a big miss in the Commerce functionality.

I'm trying to configure CA$ to display as $100.00 but when I set the Code Placement to "Hidden" and Save the form it keeps coming back to "After" - quite irritating really.

Hopefully this is just a case of the code not writing to the DB properly..

Comments

facine’s picture

denisgre’s picture

Hi Manuel,

The patch appears to work well - my site has lost a lot of weight all of a sudden :-).

I will let you know if any other issues show up, otherwise, I think this should be added to the DEV branch ASAP.

Best,

Denis.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ankur.khurana3’s picture

Not Working For Me. The Issue still Exists. I am unable to save the Settings. It just toggle back to the original values.

facine’s picture

Which version are you using?
What no hard currency?
And what values ​​not saved?

Thanks

eworwa’s picture

Hi, I'm facing the same problem. I already installed the dev version of the module. I set the Code Placement to "Hidden" and Save the form it keeps coming back to "After". But when I set the Code Placemente to "Before" the price it's formatted correctly, so the data it's getting storage in db. I just cannot hide the code from the price output.

facine’s picture

In which currency?

dayer4b’s picture

I'm having the exact same problem as #6.

Currency is Naira (NGN)

dayer4b’s picture

Status: Closed (fixed) » Active

updated status

dayer4b’s picture

Priority: Normal » Critical

increasing priority to critical.

this bug makes this module useless to me.

facine’s picture

@dayer4b: In which version and which values​​?

Thanks

dayer4b’s picture

I'm using 7.x-1.1. I attempted to set the value of code_placement to "hidden" to no success.

webdrips’s picture

This took me forever to figure out since variable_get() is kind of funky when it comes to working with form values, but the attached patch should fix the issues of not being able to save the form, although it does break the validation, so maybe someone else can fix that based on the attached patch.

chrinor2002’s picture

StatusFileSize
new713 bytes

Hi there, I managed to track down the issue to be in the commerce_currency_settings_settings_form_validate() call. The validate uses array_diff() to compare settings provided in the core of commerce with settings applied by the user. The problem is that array_diff() does not work with keys AND values, just values. Here is a patch that will use array_diff_assoc().

tomrishworth’s picture

Patch in #14 fixes this issue for me.
Thanks

facine’s picture

Status: Active » Fixed

Commited in dev version!

Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.