Recently my hosting provider moved my site to a brand new server with PHP 5.4. Now it spends less memory per a page load, and it's much, much faster. The only issue I've spotted is with this module, that throws many strict warnings e.g.:

Strict warning: Non-static method BotchaModel::getRecipebooksForms() should not be called statically, assuming $this from incompatible context in BotchaModel->getFormsRecipebooks() (line 146 of /home/user/public_html/sites/all/modules/botcha/model/application/botcha.application.model.inc).

Strict warning: Non-static method BotchaModel::getFormsRecipebooks() should not be called statically, assuming $this from incompatible context in BotchaFormAbstract->getRecipebook() (line 165 of /home/user/public_html/sites/all/modules/botcha/controller/form/botcha.form.controller.inc).

Comments

PatchRanger’s picture

PatchRanger commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Active » Patch (to be ported)

Thanks for reporting, fixed for D7: http://drupalcode.org/project/botcha.git/commit/71a5ca6.
Needs to be ported to D6.

jazzitup’s picture

jazzitup commented

Thanks for resolving this lightning fast!

PatchRanger’s picture

PatchRanger commented

@jazzitup You are welcome. 6.x-3.x port of it is coming.

PatchRanger’s picture

PatchRanger commented
Status: Patch (to be ported) » Fixed

Fixed for D6 too: http://drupalcode.org/project/botcha.git/commit/27bd7ce.

salvis’s picture

salvis
he/his
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Active

More of these on admin/config/development/testing. Click [Clean environment] or flush the cache:

Strict warning: Declaration of BotchaHoneypotTestCase::setFormValues() should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in _registry_check_code() (line 1127 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaHoneypot2TestCase::setFormValues() should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in _registry_check_code() (line 1159 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaObscureUrlTestCase::setFormValues() should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in _registry_check_code() (line 1190 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaNoResubmitTestCase::setFormValues() should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in _registry_check_code() (line 1281 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaNoResubmitTestCase::assertFormSubmission() should be compatible with BotchaBaseWebTestCase::assertFormSubmission($form, $edit, $should_pass = true, $button = NULL, &$parameters = Array) in _registry_check_code() (line 1281 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaTimegateTestCase::setFormValues() should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in _registry_check_code() (line 1356 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: Declaration of BotchaTimegateTestCase::assertFormSubmission() should be compatible with BotchaBaseWebTestCase::assertFormSubmission($form, $edit, $should_pass = true, $button = NULL, &$parameters = Array) in _registry_check_code() (line 1356 of sites\all\modules\botcha\tests\botcha.simpletest.test).

Strict warning: call_user_func() expects parameter 1 to be a valid callback, non-static method RelationViewsTestCase::getInfo() should not be called statically in call_user_func() (line 327 of modules\simpletest\simpletest.module).

(Not sure whether you prefer having a new issue or continuing the old one...)

PatchRanger’s picture

PatchRanger commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Active » Patch (to be ported)

@salvis Thanks, I don't mind which way you report a bug :)
Fixed for D7: http://drupalcode.org/project/botcha.git/commit/d099711. It was just a silly definition typo, which caused so many warnings.

PatchRanger’s picture

PatchRanger commented
Status: Patch (to be ported) » Fixed

Fixed for D6 as well: http://drupalcode.org/project/botcha.git/commit/edc5774.
If you have any other problems with fresh distributive, feel free to report any way you like.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

PatchRanger’s picture

PatchRanger commented

Fixed for both 7.x-4.x & 6.x-4.x by changing common part ("library"): http://drupalcode.org/project/botcha.git/commit/048bfdf1c02f5f98cbfe0bf0... .

rudolfbyker’s picture

rudolfbyker
Primary language Afrikaans
Location South Africa
commented
Issue summary: View changes

The same problem that was solved here seems to be back on the 7.x-3.x branch.

Warning: Declaration of BotchaHoneypotTestCase::setFormValues($form, $should_pass, &$parameters = Array) should be compatible with BotchaBaseWebTestCase::setFormValues($form, $should_pass = true, &$parameters = Array) in include_once() (line 0 of /var/www/cl_alt1/web/sites/all/modules/botcha/tests/botcha.simpletest.test)

etc...