As #1868680: Default text format for blog comments should be Filtered HTML, not Commerce Order Message issue describes, the "Commerce Order Message" filter format becomes the default format
because of its weight and name.
I think it's best to change the weight to a higher value.

CommentFileSizeAuthor
#14 fix_notice_error_messages_for_some_textareas-1872062-14.patch665 bytesvasike
#9 issue-1872062.patch1.56 KBlsolesen
#8 issue-1872062.patch1.56 KBlsolesen
#6 limit_commerce_order_message_format_usage-1872062-6.patch1.54 KBvasike
#1 change_the_weight_for_filter_format-1872062-1.patch844 bytesvasike

Comments

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new change_the_weight_for_filter_format-1872062-1.patch844 bytes

here is patch for this

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Active » Needs review
bojanz’s picture

bojanz commented
Status: Needs review » Needs work

This will also make it the non-default format for adding messages, which means it starts having little point.

We might need a different fix for #1868680: Default text format for blog comments should be Filtered HTML, not Commerce Order Message

vasike’s picture

vasike
Location Ramnicu Valcea
commented

what about a new approach, having this format available only for "message_type" entities?

bojanz’s picture

bojanz commented

That would make sense.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Title: Change the weight for the Commerce Order Message filter format » Commerce Order Message filter format available only for Message Types entities
Status: Needs work » Needs review
StatusFileSize
new limit_commerce_order_message_format_usage-1872062-6.patch1.54 KB

here is patch for the new approach. ReTitled

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Priority: Normal » Major

i think this is pretty serious for Commerce Kickstart.

lsolesen’s picture

lsolesen commented
Issue summary: View changes
StatusFileSize
new issue-1872062.patch1.56 KB

Rerolled against latest dev.

lsolesen’s picture

lsolesen commented
StatusFileSize
new issue-1872062.patch1.56 KB
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks.

  • Commit 150a2f6 on 7.x-1.x authored by vasike, committed by bojanz: 
    Issue #1872062 by lsolesen, vasike: Commerce Order Message filter format...
malberts’s picture

malberts commented
Status: Fixed » Needs work

I hope it's okay to change the status.

After upgrading from RC1 to RC2 I'm seeing the following on some pages:

Notice: Undefined index: #entity_type in commerce_message_filter_process_format() (line 136 of ... commerce_message/commerce_message.module)

One case where it happens is for example where admin edits his own profile (user/1/edit). I haven't made any changes to user profiles.

Edit: The same happens when I add RC2 to Commerce Kickstart 2.14

derekw’s picture

derekw commented

Seeing the same message above (but it's line 135) with RC2.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs work » Needs review
StatusFileSize
new fix_notice_error_messages_for_some_textareas-1872062-14.patch665 bytes

@malberts, @derekw : indeed. Thank you.

there is a patch that should get rid of the error notice.

malberts’s picture

malberts commented
Status: Needs review » Reviewed & tested by the community

I think RTBC is in order. It's a simple enough change.

bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Sorry, I already pushed a fix (went with an isset). Let me know how it works.

  • Commit ffdb79f on 7.x-1.x by bojanz: 
    Issue #1872062 followup: Fix notice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.