Croninfinite looks to do exactly what I want to do, however I am using a completely secured website (no http, only https). Croninfinite makes the assumption (croninfinite.module line 51) that the site is not secured by hard-coding "http://" in drupal_http_request(). Can this please be changed to work with sites that use https instead of http.

Comments

patrickd’s picture

patrickd commented
Category: support » bug
Status: Active » Needs review

Absolutely right, sorry! (this one was my first drupal module and I had no time to have another look at it^^)

Instead of concatenating the URL manually I should have used the 'absolute' => TRUE, option of url() which will take care of protocols automatically.

Tested and committed the following to 7.x-1.x

--- a/croninfinite.module
+++ b/croninfinite.module
@@ -48,7 +48,7 @@ function croninfinite_start() {
 
   // Send HTTP request to croninfinite.php script.
   $result = drupal_http_request(
-    url('http://' . $_SERVER['SERVER_NAME'] . base_path() . drupal_get_path('mo
+    url(drupal_get_path('module', 'Croninfinite') . '/croninfinite.php',
       array(
         'query' => array(
           // As the script does not use Drupal's bootstrap we have to
@@ -62,6 +62,7 @@ function croninfinite_start() {
           'drupal_root_path' => getcwd(),
           'phase' => 'start',
         ),
+        'absolute' => TRUE,

Stupid fault but easily fixed :)

If this also resolves the error for you I'm going to create a new release asap

thanks for reporting

orbmantell’s picture

orbmantell commented
Status: Needs review » Reviewed & tested by the community

Thank you, that fixes things nicely.

patrickd’s picture

patrickd commented
Status: Reviewed & tested by the community » Fixed

great! :) release is on the way

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.