Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.It seems like the check-to-delete form in the admin interface does not work. The attached patch turns the separate checkbox elements into a single checkboxes element and slightly reworks the deletion iteration. It seems to work fine for me but could probably use review and testing.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | ezmlm-7.x-1.1_cleanup.patch | 11.11 KB | HorsePunchKid |
| ezmlm-7.x-1.1_delete_fix_0.patch | 2.33 KB | HorsePunchKid |
Comments
Comment #1
HorsePunchKid commentedHere is a more comprehensive patch that I believe also fixes some issues in the admin interface but primarily is aimed at cleaning up the code. The main change is to make
_ezmlm_get_lists()always return an array instead of leaving it to the caller to guess whether an array or empty string was returned. Using this function consistently instead of callingvariable_getalso helps clean things up.I have tested this somewhat, including the odd variations like adding a list at the same time as deleting another list, and it seems to work fine. More testing would probably be useful, though.
This patch does not include the above patch fixing deletion. I can reroll it if necessary.
Comment #2
hutch commentedI will review these patches shortly, it's been a long time since I looked at the ezmlm module code ;-)
Comment #3
hutch commentedThe above patches went in clean, I have reinstated the registration list description as that came about from some user feedback, ran coder review and cleaned that up, commited to dev.
Thank you for providing these fixes, much better!
Comment #4
hutch commentedA new release is now available for D6 and D7