This code will only apply the picturefill to the first child:

window.picturefill(context[0]);

Patch coming in a sec.

What do you think of giving me commit access? Would love to help you maintain this module.

CommentFileSizeAuthor
#10 1851660-behavior-10.patch650 bytesluksak
#1 1851660-behavior-2.patch449 bytesluksak

Comments

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
StatusFileSize
new 1851660-behavior-2.patch449 bytes
attiks’s picture

attiks commented
Status: Needs review » Fixed

strange patch, I added it by hand, but seems to work. Did you test this with 'old' browsers as well?

Pushed to demo as well

attiks’s picture

attiks commented

"What do you think of giving me commit access? Would love to help you maintain this module." the problem is that this has to stay in sync with Drupal 8, so people will be able to upgrade easily. This means we cannot add whatever we want to it, that's why I prefer to act as 'gatekeeper', but I might change my mind in the future.

luksak’s picture

luksak
he/him
commented

Great thank you.

Well, no... I only tested in modern browsers and IE7-8

"What do you think of giving me commit access? Would love to help you maintain this module." the problem is that this has to stay in sync with Drupal 8, so people will be able to upgrade easily. This means we cannot add whatever we want to it, that's why I prefer to act as 'gatekeeper', but I might change my mind in the future.

That's ok. However I would like to help you anyway. I filed that issue a few weeks back against D8 to add a new component for this module: #1836418: Create a issue queue component for the picture module That way I could help you better. Where are the issues at the moment? Did you commit everything we did on D7 to D8?

attiks’s picture

attiks commented

I can no longer commit to D8, related issue:

#1836860: Picture doesn't work with AJAX callback
#1836418: Create a issue queue component for the picture module

attiks’s picture

attiks commented

Another related on #1848500: Use performance optimized matchmedia polyfill

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit fc732bf on 7.x-1.x, picturefill2 authored by Lukas von Blarer, committed by attiks: 
    Issue #1851660 by Lukas von Blarer: Fixed Beavior is only taking first...

  • Commit fc732bf on 7.x-1.x, picturefill2, 7.x-2.x authored by Lukas von Blarer, committed by attiks: 
    Issue #1851660 by Lukas von Blarer: Fixed Beavior is only taking first...
luksak’s picture

luksak
he/him
commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
StatusFileSize
new 1851660-behavior-10.patch650 bytes

I had a hard time to understand why this broke again... It seems that the code got committed again... Attaching the patch that reverts this change again... It should be fixed in 2.x as well.

attiks’s picture

attiks commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

fixed in 1.x

attiks’s picture

attiks commented
Status: Needs review » Fixed

Thanks

  • Commit 3d3ee27 on 7.x-1.x authored by Lukas von Blarer, committed by attiks: 
    Issue #1851660 by Lukas von Blarer: Beavior is only taking first child...
luksak’s picture

luksak
he/him
commented

Wow, that was fast :) Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.