Contact Attach currently uses a managed file field when the file module is enabled. This is an intended feature, but a user should be able to override this and use a simple file field even when the file module is enabled. An upgrade path from beta2 should be written to automatically toggle this setting (use simple file field) for existing users, as changing from a simple file field to a managed file field (if the file module is enabled) should not come as a surprise for sites that already use the module.
Also add tests for the toggle on the settings form and that the setting actually works on the site-wide contact form and personal contact forms.

CommentFileSizeAuthor
contact-attach-simple-field-toggle-0.patch8.41 KBTor Arne Thune

Comments

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs review » Fixed

Committed and pushed: 1b3836f.

hass’s picture

hass commented
Status: Fixed » Needs work

What does this technically mean? Can we change the description so that non-technican people have a chance to understand what this option does, please?

Managed means it is saved in drupal permanently? The site mails are not saved... Why should the files saved?

Tor Arne Thune’s picture

Tor Arne Thune commented

The core file module provides a managed_file field that has more features (like an upload button using Ajax) than the simple file field provided by the system module. The toggle is for those that prefer to use the simple version of the file field, for whatever reasons. It's meant to give a choice to the user. I can see how it can be confusing for users that don't know the difference. Will try to come up with a better explanation when I find time.

hass’s picture

hass commented

I have been asked about privacy and if the mails and file will be saved. I said - no we are not reading the mails. Data protection is high.

Please take care that the files are no longer saved than required to send the mail out. I personally see no reason to add these files to the database. They should just go into temp and get deleted "a second" later. I have no idea why it should not possible to port the ajax stuff to unmanaged files, but have not reviewed the core code.

Tor Arne Thune’s picture

Tor Arne Thune commented

Created an issue to improve the help text: #1853488: Improve help text for simple file field toggle.

Tor Arne Thune’s picture

Tor Arne Thune commented

The files are registered in the database table file_managed also when using a non-managed file field (the simple version provided by the system module). The file attachments are deleted at the next cron run after DRUPAL_MAXIMUM_TEMP_FILE_AGE (21600 seconds).

You are right that they could be deleted right after they are base64 encoded into the message. Will open an issue for it.

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.