Closed (fixed)
Project:
Features Translations (D7, obsolete)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Nov 2012 at 12:00 UTC
Updated:
25 Mar 2014 at 20:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
infojunkieCommitted. Thanks!
Comment #3
drifter commentedIn fact, this bug reappeared with the introduction of the translations_features_string_source_language() check. The basic problem I think is that the default, built-in string translations always have English as the source language, while i18n strings could have different languages (for example, on our site the default language is Hungarian, i18nstrings uses Hungarian as a default, but interface strings are based on English of course).
Attached is a patch that takes this into account, this allowed me to download my translated strings.
Comment #4
infojunkieThanks. Can you point to relevant code from Drupal core or i18n module to *prove* that the default text group's source language is always English? I will look too, but it would be good to get confirmation from you as well.
Comment #5
drifter commentedStrings enclosed in the t() function, which is what the default text group is, should always be English, since that is what Drupal core and contrib authors use.
See for example:
https://drupal.org/node/1279668
"In contrast to Drupal's standard localization system, which always translates from English, [i18n] strings will be translated from the source language."
Also see locale.inc and locale.module, for instance in locale.inc:
Comment #6
infojunkieThanks for going the extra step. Committed your fix to the latest dev.
Comment #7
infojunkie