Happy this theme is being backported and cool work all around. I checked it out and saw an issue with the way #content was given width. In cases where there are sidebars, it is set appropriately. But there is no handling for when there are .no-sidebars.

CommentFileSizeAuthor
#3 selection023k.png165.19 KBdsnopek
#3 selection024n.png163.79 KBdsnopek
#1 1835960-no-sidebar-width-content-1.patch326 bytespopulist

Comments

populist’s picture

populist commented
Status: Active » Needs review
StatusFileSize
new 1835960-no-sidebar-width-content-1.patch326 bytes

Here is a patch that just sets #content to 100% if there are no sidebars.

mjohnq3’s picture

mjohnq3 commented
Status: Needs review » Postponed (maintainer needs more info)

Thanks but I'm not understanding why this is necessary. In what situations would the content area, without sidebars, be anything other than 100% at screen sizes greater than 851px?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
StatusFileSize
new selection024n.png163.79 KB
new selection023k.png165.19 KB

This patch works great for me!

I've attached two images - one which shows a test page without the patch, and the next with the patch. The one without squishes the content over to the left, leaving a big blank area on the right.

As far as why it doesn't work without the patch, I haven't personally had a chance to look into it.

BEFORE PATCH:

AFTER PATCH:

I hope that helps!

mjohnq3’s picture

mjohnq3 commented

Ok, I'm convinced. This will be added to the upcoming beta release.

mjohnq3’s picture

mjohnq3 commented
Status: Reviewed & tested by the community » Fixed

Added to beta1 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.