Closed (fixed)
Project:
Random Fonts
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Oct 2012 at 17:05 UTC
Updated:
29 Nov 2012 at 15:40 UTC
Jump to comment: Most recent file
Hmmm... Randomly selecting fonts, which breaks the consistency of layout... Might consider adding a dependency on the Bad Judgement module...? ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | random_fonts-Minimize_chance_of_accidental_screwup_by_making_limited_display_default-1810192-4.patch | 2.42 KB | Drave Robber |
Comments
Comment #1
Drave Robber commentedThis was in the initial plan, but then I added an option to limit effects to admin users (those with 'administer @font-your-face' permission), and the module started to seem much less dangerous.
Now that I think of it, flipping the default value of that option would lower the probability of screwing up in case someone enables this on a live site without reading the documentation first.
Would that be enough?
Comment #2
arpieb commentedI was more or less picking on you about random fonts - sounded like something Dave Reid or mbutcher would come up with during a night of drinking at a 'Con. :)
A default setting of "off" would probably be advisable though... ;)
Comment #3
Drave Robber commentedThis module was indeed conceived in the middle of the night, although no company or beverages other than coffee were involved. :)
I still think however it can be useful to discover font combinations that one would not have thought of otherwise.
Comment #4
Drave Robber commentedThe attached patch flips the default value of random_fonts_restricted variable and also strives to improve wording/documentation a bit.
Comment #5
Drave Robber commentedNow that Edge Fonts is in (see #1794540: Add Edge fonts submodule), I'm preparing to roll this module out; therefore, #4 has been committed.
Feel free to reopen if you see something else that should or could be done to make it safer.