I'm no Drupal expert (actually I know nothing about it) but I do know PHP and understant how it works.

I just read your code to use it for a PHP framework and just notice something which seems to me to be a typo mistake. The use of drupal_static() has no effect becaue line 120 is :

if (!isset($function)) {

and should be (missing 's') :

if (!isset($functions)) {

Comments

steven jones’s picture

Status: Active » Needs review
StatusFileSize
new474 bytes

Thanks for spotting this, patch attached.

Status: Needs review » Needs work

The last submitted patch, sassy-1788924-typo-function.patch, failed testing.

steven jones’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review

This needs to be against the 2.x branch.

steven jones’s picture

#1: sassy-1788924-typo-function.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: sassy-1788924-typo-function.patch, failed testing.

joseph.olstad’s picture

Issue summary: View changes
StatusFileSize
new474 bytes

Try this patch instead

joseph.olstad’s picture

Status: Needs work » Needs review

  • joseph.olstad committed 3078f9a on 7.x-2.x
    Issue #1788924 by Steven Jones, joseph.olstad: Typo mistake in sassy....
joseph.olstad’s picture

fixed

joseph.olstad’s picture

Status: Needs review » Fixed

Status: Fixed » Needs work

The last submitted patch, 6: sassy_typo_function-1788924-06.patch, failed testing.

joseph.olstad’s picture

Status: Needs work » Fixed

This was fixed, it won't apply because it's already applied.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 6: sassy_typo_function-1788924-06.patch, failed testing.

joseph.olstad’s picture

Status: Needs work » Closed (fixed)

this was already committed, so the patch will no longer apply and is no longer testable