There are few messages in Drupal that scare me more than:

> You must enable the PHP filter module to install Panopoly News.
> Would you like to continue with the above?

CommentFileSizeAuthor
#1 panopoly_news-n1707142.patch373 bytesdamienmckenna

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new373 bytes

What happens if you disable the PHP module (see attached)? I coudn't find any occurrences of "php" that weren't for the syntax delimeter, i.e. "<?php".

pirog’s picture

@populist, no, it doesn't need to be there. I think we were using it at very early stages of development and must have forgotten to remove it.

With the tools we are using in ctools/panels i can't really see a reason why you would want to use this except for the most edge of cases. That being said it would probably be a good practice to discourage people from using php filter in p_apps for obvious reasons.

pirog’s picture

Status: Needs review » Closed (fixed)

also, committed.

pirog’s picture

Issue summary: View changes

Making it clear the fear of god was put in me by Drupal