Lines 44 & 45 in settings_audit_log.install are:

db_query("DROP settings_audit_log_variable_update_audit");
db_query("DROP settings_audit_log_variable_insert_audit");

and they should be:

db_query("DROP TABLE settings_audit_log_user_db_connection");
db_query("DROP TABLE settings_audit_log_variable_audit_log");

Notice it said DROP instead of DROP TABLE, and the table names were wrong

and

db_query("DROP TRIGGER IF EXISTS settings_audit_log_variable_update_audit");
db_query("DROP TRIGGER IF EXISTS settings_audit_log_variable_insert_audit");

needs to be added...

Comments

Anonymous’s picture

Anonymous (not verified) commented

thanks for the report.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

Drupal 7 automatically cleans up tables on uninstall, so we don't need to do that.

i've updated the trigger code to use "DROP TRIGGER IF EXISTS", thanks.

also, i noticed that db prefixing was missing for the triggers, so i fixed that. there is no upgrade path though, this will require manually removing the triggers, then uninstalling.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Added two lines that need to be added