Create stable release of Media: YouTube for 7.x

Marked #1555276: Clean up theming function, Use recommended iframe player by default, without js as a release blocker. Major changes with relevance to most embedding modules and a lot of work are in this issue. Everybody feel free to test it.

edit: Not sure about the procedure here. This issue was opened against the 2x branch yet the criticals are mostly concerning 1x. What do we want here? A stable 1x? Or a stable 2x?

at this point, there are not too many difference between the branches, other than the YouTube tab. Thus, I believe that it would be best to fix branch 2.X, and roll back to 1.X. That said, the YouTube tab still needs some work, so I am aiming for a stable 1.X branch 1st.

#1668950: YouTube Tab: Fatal error: Cannot use string offset as array in sites/all/modules/media_youtube/media_youtube.module on line 175 seems to be pretty bad. I have to use "Enabled Browser Plugins: Web" in order to post youtube videos -- the Youtube option works ok for videos on that auto-display but if you post a youtube video ID into the box it gives the string offset error. Needs more documentation?

There are no critical bugs against 2.x now, unless HongPong's is raised up.

2.x is working well enough right now that I'd recommend it for production sites. I'd like to do some cleanup, including removing styles code, and get the js API integration running smoothly out of the box. After that, let's give 2.x a look and see if we can upgrade it to a full release.

we also need to ensure that people can upgrade smoothly between versions, before pushing a stable release. As I recall, there may be some issues after that last big patch.

@Aaron: between 7.x-1.x and 7.x-2.x, or between 6.x-1.x, 7.x-1.x and 7.x-2.x?

I did remove and rename some of the formatter options, and the theme output is significantly different. Would it be possible to create a bridge template that is only used by those upgrading from 7.x-1.x, but let all new installs use the simpler tpl? Haven't written any update scripts before.

Might want to get these changes in too:
#1497014: Couple of cleanups to MediaInternetYouTubeHandler.inc
#1320308: Add display settings for "full", "teaser", and "preview" file view mode for media_youtube

Added list of issues to summary.

Updated with issue list

added call to action.

Almost there. Going to go through the issue queue once more tomorrow and see if anything jumps out.

updated task list

added some more issues

Added some more

All major issues have been fixed and committed to 2.x-dev.

Tasks remaining:

1. Create legacy tpl and update scripts.
2. Comment out the YouTube tab and tag a release candidate.
3. Update the project page with info on the YouTube tab.

remove an issue.

Added legacy markup tpl: http://drupalcode.org/project/media_youtube.git/commit/5905583.

updated tasks

revised tasks

Added some major feature requests to keep track of.

Almost there. As far as I can tell #1402328: Preserve classes added by WYSIWYG is the last issue that needs to go in before we can roll a stable.

Added update hooks and fixed some whitespace issues in this patch. The update hook removes deprecated options from the ctools exportables, and migrates the one deprecated option that can be replicated with new settings. I couldn't find an acceptable way to feed two different tpls to a user depending on if they are updating or installing fresh -- I think 2.x being in alpha, the markup changes are fine. In Vimeo I'll bump to 2.x when that gets to release stage to avoid passive markup changes.

Adding an explanation of the legacy tpl in the readme is probably a good idea. Other suggestions/concerns?

And here's one with some general notes and a readme section on updating. Not that anyone reads them, but for the first month or so I'll add a note that if you're updating read the important notes in the readme to the front page.

[Edit] Introduced some whitespace errors in this patch. I'll clean them out next roll/apply.

added some important feature requests

Hey thanks for all the fine work -- i'm a big fan of Readmes really, i just wish d.o auto-pegged them to the module page.

This patch should bring us to 2.0-RC1, or just 2.0 if people test here and say it's looking good. Major readme update, commenting out of YouTube tab, some extra code doc, etc.

+ dpm($formatters[$formatter]);

Peer review to the rescue.

Wait, ignore this one, head to #21.

Ahem, anyways:

+      // Migrate chromeless=1 or controls='0' to autohide=1, showinfo=0.
+      if (isset($formatters[$formatter]->settings['chromeless'])) {
+        if ($formatters[$formatter]->settings['chromeless'] == 1) {
+          $formatters[$formatter]->settings['autohide'] = 1;
+          $formatters[$formatter]->settings['showinfo'] = 0;
+        }
+      }
+      if (isset($formatters[$formatter]->settings['controls'])) {
// I believe the following should be ->settings[’controls'] == 0
+        if ($formatters[$formatter]->settings['chromeless'] == 1) {
+          $formatters[$formatter]->settings['autohide'] = 1;
+          $formatters[$formatter]->settings['showinfo'] = 0;
+       }
+      }

diff --git a/includes/themes/media-youtube-video-legacy.tpl.php b/includes/themes/media-youtube-video-legacy.tpl.php
deleted file mode 100644
index eedd516..0000000
--- a/includes/themes/media-youtube-video-legacy.tpl.php
+++ /dev/null

Why are you deleting that file?

#22: Thanks! Totally correct.

#23: It's a rename from media-youtube-video-legacy.tpl.php to media-youtube-video.legacy-example.tpl.php. There's probably a way to do that where git recognizes it as a rename or move, not a delete file then create new file... I should look that up.

@RobW - git mv http://kernel.org/pub/software/scm/git/docs/git-mv.html

Fixed Aaron's catches, did one last code review, and pushed the changes plus a 2.0-rc1 tag. I'll set it as the recommended release as soon as the tag .rars are built, and we'll see if users can uncover any more issues in the next week. If not, it's 2.0 time!