When Views Bookmark is used to control various behaviors around a site (like what nodes are featured on a particular page, etc) it's a bit frustrating that the toggle is invisible when actually *editing* the node. This patch adds a new bool to each bookmark record: "Show on node edit form." When that's selected, and the currently logged in user has permission to use the bookmark, the bookmark will appear as a checkbox on the node edit form.

On the content type editing form, the default value (checked or unchecked) can also be set. This makes it possible to make certain node types bookmarked by default.

Yay.

CommentFileSizeAuthor
#4 bmf.patch8.68 KBeaton
#1 bookmark_form_field_0.patch16.7 KBeaton
bookmark_form_field.patch0 byteseaton

Comments

eaton’s picture

eaton commented
StatusFileSize
new bookmark_form_field_0.patch16.7 KB

Whoops. Rolled an empty patch. Here's the right one.

robbiethegeek’s picture

robbiethegeek commented

Hey there I was excited about this functionality so I tried to patch and got :

Hunk #1 FAILED at 56.
Hunk #2 FAILED at 68.
Hunk #3 FAILED at 79.
Hunk #4 FAILED at 92.
Hunk #5 FAILED at 132.
Hunk #6 FAILED at 247.
Hunk #7 FAILED at 263.
Hunk #8 FAILED at 276.
Hunk #9 FAILED at 304.
Hunk #10 FAILED at 354.
Hunk #11 FAILED at 373.
Hunk #12 FAILED at 499.
Hunk #13 FAILED at 668.
13 out of 13 hunks FAILED
on both the current version (5.x-1.1) and HEAD

eaton’s picture

eaton commented

The patch is rolled against the current DRUPAL-5 version, not the DRUPAL-5--1-1 release. There's no way to select the branch itself in the 'version' dropdown, unfortunately, and there are some differences between the DRUPAL-5 and DRUPAL-5--1-1 versions that make my patch apply incorrectly.

Grab the DRUPAL-5 version from CVS and apply the patch. That should do the trick!

eaton’s picture

eaton commented
StatusFileSize
new bmf.patch8.68 KB

Actually, ignore me. that patch WAS misrolled. Whoops.

eaton’s picture

eaton commented

After a brief-ish conversation with Earl, I committed this to the DRUPAL-5 dev branch. It's tested and is being used on a client site, but if there is breakage discovered I'll roll it back.

eaton’s picture

eaton commented
Status: Needs review » Fixed
robbiethegeek’s picture

robbiethegeek commented

I rabbed it from CVS and it had one error on running the updata.php but then all seems great it gives the option, they are now on the node edit and it is right there in views and works.

Thanks sirs & ladies!

robbiethegeek’s picture

robbiethegeek commented

I can't spell first. Second it appears to mess with cookies, once this is enabled, I can't log in til I drop the cookies for the site, when logged in and I go to a pagw with this module being invoked, I then am logged out and can't log back in til I dump the cookie.

eaton’s picture

eaton commented

I can't spell first. Second it appears to mess with cookies, once this is enabled, I can't log in til I drop the cookies for the site, when logged in and I go to a pagw with this module being invoked, I then am logged out and can't log back in til I dump the cookie.

That doesn't make much sense at all -- this patch added *nothing* that even remotely involves cookies. Is it possible that other changes to the DRUPAL-5 branch, since the DRUPAL-5--1-1 version was released, could be causing those problems?

robbiethegeek’s picture

robbiethegeek commented

OK while it make make no sense but those were the experiences that this want to be tester experienced :)

Once I disabled the module, cleared the cookie, and deleted the filter from the view I had created the site went straight back to functional.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)