See http://api.drupal.org/api/drupal/includes%21common.inc/function/format_u...
Return value
An unsanitized string with the username to display. The code receiving this result must ensure that check_plain() is called on it before it is printed to the page.
See includes/login_history.admin.inc:
http://drupalcode.org/project/login_history.git/blob/refs/heads/7.x-1.x:...
http://drupalcode.org/project/login_history.git/blob/refs/heads/7.x-1.x:...
This issue is safe to be reported in public since this module has no official public release and only a dev release. This issue should block a stable release of this module because if this is not fixed then this requires an official security announcement to fix.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1580798_loginhistory_xss_formatusername.patch | 1.92 KB | greggles |
Comments
Comment #0.0
dave reidAdding note about blocking stable release.
Comment #1
dave reidComment #2
gregglesSomething like this?
Comment #3
greggleshttp://drupalcode.org/project/login_history.git/commit/8fb0634
Thanks, Dave!
Comment #4
dave reidI won't tell anyone that this patch was needed. It'll be our secret!
Comment #5.0
(not verified) commentedSpelling error.