Downloading and then moving a file can be slow - especially if the temp directory and the filesystem for Drupal are not on the same device.

Alan has been working on a fix using a atomic renam to minimize the window where a file may go missing or have truncated content.

Comments

pwolanin’s picture

Status: Active » Needs review
StatusFileSize
new3.47 KB
pwolanin’s picture

pwolanin’s picture

Status: Needs review » Fixed

committed

pwolanin’s picture

Status: Fixed » Active

oops, Alan points out in the case where we are re-aggregating we need $success to default to TRUE.

pwolanin’s picture

Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new622 bytes
pwolanin’s picture

StatusFileSize
new12.8 KB

moves tests to a sub-directory, fixes the test in terms of admin theme permission added in and adds a test that should

re: admin theme see: #1423370: JavaScript libraries aren't loaded on some 403 pages or on "admin" pages that really aren't for admins

pwolanin’s picture

StatusFileSize
new896 bytes

committed that, but I'm concerned the condition is still not correct.

Here's a test that show it failing.

pwolanin’s picture

StatusFileSize
new896 bytes

reposting for testbot

Status: Needs review » Needs work

The last submitted patch, 1561496-7.patch, failed testing.

pwolanin’s picture

Status: Needs work » Needs review
StatusFileSize
new1.54 KB

Here's with another fix that satisfies the added test case in #10.

pwolanin’s picture

Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.