Closed (fixed)
Project:
JavaScript Libraries Manager
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 May 2012 at 17:28 UTC
Updated:
21 May 2012 at 19:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
pwolanin commentedComment #2
pwolanin commentedupdated patch for commit in #1545164: Full absolute url is returned to core JS aggregation, requiring HTTP request to aggregate file contents
Comment #3
pwolanin commentedcommitted
Comment #4
pwolanin commentedoops, Alan points out in the case where we are re-aggregating we need $success to default to TRUE.
Comment #5
pwolanin commentedComment #6
pwolanin commentedmoves tests to a sub-directory, fixes the test in terms of admin theme permission added in and adds a test that should
re: admin theme see: #1423370: JavaScript libraries aren't loaded on some 403 pages or on "admin" pages that really aren't for admins
Comment #7
pwolanin commentedcommitted that, but I'm concerned the condition is still not correct.
Here's a test that show it failing.
Comment #8
pwolanin commentedreposting for testbot
Comment #10
pwolanin commentedHere's with another fix that satisfies the added test case in #10.
Comment #11
pwolanin commentedcommitted