Don't use drupal_goto in form submission

In promotion_form_submit(), drupal_goto() is used to redirect after the form has been submitted. However, it is better to return the path and let the Forms API do the redirect. This will allow other modules to use #submit when altering promotion_form and be called on submission.