Values like +37° 23' 46.26" are not correctly accounted for in the code, because . chars are stripped. I'll be attaching a patch which corrects this issue and properly converts such values to decimal. Thanks for the module!

CommentFileSizeAuthor
#3 location_feeds-account_for_decimal_second_values_with_tests-1440200-3.patch2.64 KBacrollet
#1 location_feeds-account_for_decimal_second_values-1440200-1.patch557 bytesacrollet

Comments

acrollet’s picture

acrollet commented
Status: Active » Needs review
StatusFileSize
new location_feeds-account_for_decimal_second_values-1440200-1.patch557 bytes

Patch attached, Works for Me. (TM)

elliotttf’s picture

elliotttf commented

Patch looks simple enough. Mind updating the simpletests to account for this case?

acrollet’s picture

acrollet commented
StatusFileSize
new location_feeds-account_for_decimal_second_values_with_tests-1440200-3.patch2.64 KB

New patch attached with test cases for locations in each quadrant. While I was at it, I also added code to account for co-ordinates in the following format: 13° 09' 47" S, 72° 32' 44" W. Test passes on my system...

elliotttf’s picture

elliotttf commented
Status: Needs review » Patch (to be ported)

Awesome, thanks! I've applied this to the 7.x branch, will back port to 6.x then do a release.

acrollet’s picture

acrollet commented

cool!

elliotttf’s picture

elliotttf commented
Status: Patch (to be ported) » Fixed

Just tagged the releases, whenever they get built this'll be live. Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.