The current version of PAReview.sh is stricter than the one this module passed during its code review.

CommentFileSizeAuthor
#1 coding-standards-1365700-1.patch6.81 KBbenjifisher

Comments

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
StatusFileSize
new coding-standards-1365700-1.patch6.81 KB

The attached patch fixes the errors reported by PAReview.sh.

summit’s picture

summit commented

Hi, would love to see this committed.
greetings, Martijn

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Status: Active » Fixed

Martijn:

It looks as though I already committed it. In fact, I created the issue so that I could have something to reference in the commit message. But then I forgot to close the issue.

Ideally, I like to have someone mark my patch as RTBC before I commit it, but on a tiny project like this, that is unrealistic.

Maybe it is time to release 7.x-1.0. The patch discussed here was committed to the git version, but it is not in 7.x-1.0-rc1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.